Skip to content

Add button in settings to clear reCAPTCHA cookies#4453

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
wb9688:clear-cookies
Oct 16, 2020
Merged

Add button in settings to clear reCAPTCHA cookies#4453
TobiGr merged 1 commit intoTeamNewPipe:devfrom
wb9688:clear-cookies

Conversation

@wb9688
Copy link
Member

@wb9688 wb9688 commented Oct 8, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add button in settings to clear reCAPTCHA cookies

Fixes the following issue(s)

Fixes #4279

Testing apk

app-debug.apk.zip

Agreement

@wb9688 wb9688 added the feature request Issue is related to a feature in the app label Oct 8, 2020
@wb9688 wb9688 requested a review from Stypox October 8, 2020 17:35
@wb9688 wb9688 mentioned this pull request Oct 9, 2020
Closed
4 tasks
TobiGr
TobiGr previously approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Did not test, but I guess, you did :)

@TobiGr TobiGr added the privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses label Oct 9, 2020
Stypox
Stypox requested changes Oct 10, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, too, I don't see why it shouldn't work, though I will test.

@wb9688 could you provide an APK?

@wb9688 wb9688 requested a review from Stypox October 14, 2020 12:04
Stypox
Stypox requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Shouldn't the preference be disabled or hidden when there are no cookies to clear?

@wb9688 wb9688 requested a review from Stypox October 14, 2020 12:39
@wb9688
Copy link
Member Author

wb9688 commented Oct 14, 2020

@Stypox: Now it's hidden when there's no cookie (and will hide when you press it). I confirmed that it works using Stetho.

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Oct 14, 2020

Does it always check for "no cookie" before hiding or does tapping it suffice? In other words, does it assume the operation will succeed or does it wait and check that cookies have been cleared before hiding? Is hiding prevented if the operation fails for whatever reason?

@Stypox
Copy link
Member

Stypox commented Oct 14, 2020

Either the operation fails making the app crash before it gets to hide the button or the operation succeeds thus correctly hiding the button. So there is no room for inconsistency here

Stypox
Stypox approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@TobiGr TobiGr merged commit 3c5ed2c into TeamNewPipe:dev Oct 16, 2020
This was referenced Nov 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr left review comments

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

feature request Issue is related to a feature in the app privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to delete google cookies

4 participants

@wb9688 @opusforlife2 @Stypox @TobiGr